[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 4/5] block/blkreplay: Remove protocol-related fie
From: |
Fabiano Rosas |
Subject: |
[Qemu-block] [PATCH v2 4/5] block/blkreplay: Remove protocol-related fields |
Date: |
Mon, 12 Mar 2018 19:07:52 -0300 |
The blkreplay driver is not a protocol so it should implement bdrv_open
instead of bdrv_file_open and not provide a protocol_name.
Attempts to invoke this driver using protocol syntax
(i.e. blkreplay:<filename:options:...>) will now fail gracefully:
$ qemu-img info blkreplay:foo
qemu-img: Could not open 'blkreplay:foo': Unknown protocol 'blkreplay'
Signed-off-by: Fabiano Rosas <address@hidden>
Reviewed-by: Pavel Dovgalyuk <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
block/blkreplay.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/blkreplay.c b/block/blkreplay.c
index 61e44a1949..fe5a9b4a98 100755
--- a/block/blkreplay.c
+++ b/block/blkreplay.c
@@ -129,10 +129,9 @@ static int coroutine_fn
blkreplay_co_flush(BlockDriverState *bs)
static BlockDriver bdrv_blkreplay = {
.format_name = "blkreplay",
- .protocol_name = "blkreplay",
.instance_size = 0,
- .bdrv_file_open = blkreplay_open,
+ .bdrv_open = blkreplay_open,
.bdrv_close = blkreplay_close,
.bdrv_child_perm = bdrv_filter_default_perms,
.bdrv_getlength = blkreplay_getlength,
--
2.13.6
- [Qemu-block] [PATCH v2 0/5] block: Ensure non-protocol drivers can only be selected explicitly, Fabiano Rosas, 2018/03/12
- [Qemu-block] [PATCH v2 1/5] block/replication: Remove protocol_name field, Fabiano Rosas, 2018/03/12
- [Qemu-block] [PATCH v2 3/5] block/throttle: Remove protocol-related fields, Fabiano Rosas, 2018/03/12
- [Qemu-block] [PATCH v2 2/5] block/quorum: Remove protocol-related fields, Fabiano Rosas, 2018/03/12
- [Qemu-block] [PATCH v2 4/5] block/blkreplay: Remove protocol-related fields,
Fabiano Rosas <=
- [Qemu-block] [PATCH v2 5/5] include/block/block_int: Document protocol related functions, Fabiano Rosas, 2018/03/12
- Re: [Qemu-block] [PATCH v2 0/5] block: Ensure non-protocol drivers can only be selected explicitly, Kevin Wolf, 2018/03/20