[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 2/5] block/quorum: Remove protocol-related fields
From: |
Fabiano Rosas |
Subject: |
[Qemu-block] [PATCH v2 2/5] block/quorum: Remove protocol-related fields |
Date: |
Mon, 12 Mar 2018 19:07:50 -0300 |
The quorum driver is not a protocol so it should implement bdrv_open
instead of bdrv_file_open and not provide a protocol_name.
Attempts to invoke this driver using protocol syntax
(i.e. quorum:<filename:options:...>) will now fail gracefully:
$ qemu-img info quorum:foo
qemu-img: Could not open 'quorum:foo': Unknown protocol 'quorum'
Signed-off-by: Fabiano Rosas <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
block/quorum.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/quorum.c b/block/quorum.c
index 14333c18aa..cfe484a945 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -1098,11 +1098,10 @@ static void quorum_refresh_filename(BlockDriverState
*bs, QDict *options)
static BlockDriver bdrv_quorum = {
.format_name = "quorum",
- .protocol_name = "quorum",
.instance_size = sizeof(BDRVQuorumState),
- .bdrv_file_open = quorum_open,
+ .bdrv_open = quorum_open,
.bdrv_close = quorum_close,
.bdrv_refresh_filename = quorum_refresh_filename,
--
2.13.6
- [Qemu-block] [PATCH v2 0/5] block: Ensure non-protocol drivers can only be selected explicitly, Fabiano Rosas, 2018/03/12
- [Qemu-block] [PATCH v2 1/5] block/replication: Remove protocol_name field, Fabiano Rosas, 2018/03/12
- [Qemu-block] [PATCH v2 3/5] block/throttle: Remove protocol-related fields, Fabiano Rosas, 2018/03/12
- [Qemu-block] [PATCH v2 2/5] block/quorum: Remove protocol-related fields,
Fabiano Rosas <=
- [Qemu-block] [PATCH v2 4/5] block/blkreplay: Remove protocol-related fields, Fabiano Rosas, 2018/03/12
- [Qemu-block] [PATCH v2 5/5] include/block/block_int: Document protocol related functions, Fabiano Rosas, 2018/03/12
- Re: [Qemu-block] [PATCH v2 0/5] block: Ensure non-protocol drivers can only be selected explicitly, Kevin Wolf, 2018/03/20