[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning
From: |
Richard Henderson |
Subject: |
Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning |
Date: |
Sun, 16 Aug 2020 09:03:51 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/15/20 7:31 PM, Rohit Shinde wrote:
> /* range has been completed, fall through in order to pop option */
> - __attribute__((fallthrough));
> + /* fallthrough */
(1) Any patch should not be relative to your own v3.
(2) The previous line already contains the words "fall through",
so what is it that you are trying to fix?
r~