Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

[Rohit Shinde]

Hey Richard,

1. So I should fork off the master again? I am a bit unclear on the workflow, since this is my first doing patches via format-patch and send-email so I am making mistakes.
2. I just checked and my version of the code doesn't contain that line, so I am unsure on how that line got there. I was trying to fix the compiler warnings. Could you please guide me on how I create the next version of a patch?

Thanks,

Rohit.

On Sun, Aug 16, 2020 at 12:03 PM Richard Henderson <richard.henderson@linaro.org> wrote:

On 8/15/20 7:31 PM, Rohit Shinde wrote:
>          /* range has been completed, fall through in order to pop option */
> -        __attribute__((fallthrough));
> +        /* fallthrough */

(1) Any patch should not be relative to your own v3.
(2) The previous line already contains the words "fall through",
    so what is it that you are trying to fix?


r~