On 8/16/20 5:57 PM, Rohit Shinde wrote:
> I misread the comment. The comment /* fallthrough */ was meant to stop the
> compiler warning from occurring. I am trying to complete the bite sized task
> mentioned here <https://wiki.qemu.org/Contribute/BiteSizedTasks> under
> "Compiler driven cleanups". I wanted to take that up to get more familiar with
> the codebase.
Fine, but the current comment matches the compiler regexp, so this instance
isn't part of that cleanup.
But when I was compiling with the -Wimplicit-fallthrough option, the compiler gave an error at that very line. That's why I came up on that specific line in that file first.
I am pasting the error that I got below:
home/rohit/Desktop/open-source/qemu/qapi/opts-visitor.c: In function ‘opts_next_list’:
/home/rohit/Desktop/open-source/qemu/qapi/opts-visitor.c:267:23: error: this statement may fall through [-Werror=implicit-fallthrough=]
267 | ov->list_mode = LM_IN_PROGRESS;
| ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
/home/rohit/Desktop/open-source/qemu/qapi/opts-visitor.c:270:5: note: here
270 | case LM_IN_PROGRESS: {
| ^~~~
Sending it again, because I forgot to reply all.
Thanks,
Rohit.
r~