[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning
From: |
Richard Henderson |
Subject: |
Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning |
Date: |
Sun, 16 Aug 2020 15:52:23 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/16/20 9:55 AM, Rohit Shinde wrote:
> Hey Richard,
>
> 1. So I should fork off the master again?
Yes.
There need to be special circumstances for not posting a patch set relative to
master, and even then your cover letter would need to detail against what base
the patch set applies.
> 2. I just checked and my version of the code doesn't contain that line, so I
> am unsure on how that line got there. I was trying to fix the compiler
> warnings. Could you please guide me on how I create the next version of a
> patch?
That makes no sense at all. The line was added at the same time as the code
above it, in d8754f40acb.
There should be nothing to fix.
r~