[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 06/12] libvhost-user: Change dev->postcopy_ufd assignment to m
From: |
Marcel Holtmann |
Subject: |
[PATCH v4 06/12] libvhost-user: Change dev->postcopy_ufd assignment to make it C90 compliant |
Date: |
Thu, 22 Dec 2022 21:36:45 +0100 |
The assignment of dev->postcopy_ufd can be moved into an else clause and
then the code becomes C90 compliant.
CC libvhost-user.o
libvhost-user.c: In function ‘vu_set_postcopy_advise’:
libvhost-user.c:1625:5: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
1625 | struct uffdio_api api_struct;
| ^~~~~~
Understandable, it might be desired to avoid else clauses, but in this
case it seems clear enough and frankly the dev->postcopy_ufd is only
assigned once.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
subprojects/libvhost-user/libvhost-user.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/subprojects/libvhost-user/libvhost-user.c
b/subprojects/libvhost-user/libvhost-user.c
index bf92cc85c086..b28b66cdb159 100644
--- a/subprojects/libvhost-user/libvhost-user.c
+++ b/subprojects/libvhost-user/libvhost-user.c
@@ -1599,12 +1599,13 @@ vu_set_config(VuDev *dev, VhostUserMsg *vmsg)
static bool
vu_set_postcopy_advise(VuDev *dev, VhostUserMsg *vmsg)
{
- dev->postcopy_ufd = -1;
#ifdef UFFDIO_API
struct uffdio_api api_struct;
dev->postcopy_ufd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK);
vmsg->size = 0;
+#else
+ dev->postcopy_ufd = -1;
#endif
if (dev->postcopy_ufd == -1) {
--
2.38.1
- [PATCH v4 00/12] Compiler warning fixes for libvhost-user,libvduse, Marcel Holtmann, 2022/12/22
- [PATCH v4 01/12] libvhost-user: Provide _GNU_SOURCE when compiling outside of QEMU, Marcel Holtmann, 2022/12/22
- [PATCH v4 02/12] libvhost-user: Replace typeof with __typeof__, Marcel Holtmann, 2022/12/22
- [PATCH v4 03/12] libvhost-user: Cast rc variable to avoid compiler warning, Marcel Holtmann, 2022/12/22
- [PATCH v4 04/12] libvhost-user: Use unsigned int i for some for-loop iterations, Marcel Holtmann, 2022/12/22
- [PATCH v4 06/12] libvhost-user: Change dev->postcopy_ufd assignment to make it C90 compliant,
Marcel Holtmann <=
- [PATCH v4 05/12] libvhost-user: Declare uffdio_register early to make it C90 compliant, Marcel Holtmann, 2022/12/22
- [PATCH v4 07/12] libvduse: Provide _GNU_SOURCE when compiling outside of QEMU, Marcel Holtmann, 2022/12/22
- [PATCH v4 08/12] libvduse: Switch to unsigned int for inuse field in struct VduseVirtq, Marcel Holtmann, 2022/12/22
- [PATCH v4 10/12] libvhost-user: Fix assignment in vring_set_avail_event, Marcel Holtmann, 2022/12/22
- [PATCH v4 09/12] libvduse: Fix assignment in vring_set_avail_event, Marcel Holtmann, 2022/12/22
- [PATCH v4 12/12] libvduse: Add extra compiler warnings, Marcel Holtmann, 2022/12/22
- [PATCH v4 11/12] libvhost-user: Add extra compiler warnings, Marcel Holtmann, 2022/12/22
- Re: [PATCH v4 00/12] Compiler warning fixes for libvhost-user,libvduse, Paolo Bonzini, 2022/12/23