[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 10/12] libvhost-user: Fix assignment in vring_set_avail_event
From: |
Marcel Holtmann |
Subject: |
[PATCH v4 10/12] libvhost-user: Fix assignment in vring_set_avail_event |
Date: |
Thu, 22 Dec 2022 21:36:49 +0100 |
Since it was proposed to change the code in libvduse.c to use memcpy
instead of an assignment, the code in libvhost-user.c should also be
changed to use memcpy.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
---
subprojects/libvhost-user/libvhost-user.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/subprojects/libvhost-user/libvhost-user.c
b/subprojects/libvhost-user/libvhost-user.c
index b28b66cdb159..fc69783d2bf6 100644
--- a/subprojects/libvhost-user/libvhost-user.c
+++ b/subprojects/libvhost-user/libvhost-user.c
@@ -2478,14 +2478,13 @@ vring_used_flags_unset_bit(VuVirtq *vq, int mask)
static inline void
vring_set_avail_event(VuVirtq *vq, uint16_t val)
{
- uint16_t *avail;
+ uint16_t val_le = htole16(val);
if (!vq->notification) {
return;
}
- avail = (uint16_t *)&vq->vring.used->ring[vq->vring.num];
- *avail = htole16(val);
+ memcpy(&vq->vring.used->ring[vq->vring.num], &val_le, sizeof(uint16_t));
}
void
--
2.38.1
- [PATCH v4 00/12] Compiler warning fixes for libvhost-user,libvduse, Marcel Holtmann, 2022/12/22
- [PATCH v4 01/12] libvhost-user: Provide _GNU_SOURCE when compiling outside of QEMU, Marcel Holtmann, 2022/12/22
- [PATCH v4 02/12] libvhost-user: Replace typeof with __typeof__, Marcel Holtmann, 2022/12/22
- [PATCH v4 03/12] libvhost-user: Cast rc variable to avoid compiler warning, Marcel Holtmann, 2022/12/22
- [PATCH v4 04/12] libvhost-user: Use unsigned int i for some for-loop iterations, Marcel Holtmann, 2022/12/22
- [PATCH v4 06/12] libvhost-user: Change dev->postcopy_ufd assignment to make it C90 compliant, Marcel Holtmann, 2022/12/22
- [PATCH v4 05/12] libvhost-user: Declare uffdio_register early to make it C90 compliant, Marcel Holtmann, 2022/12/22
- [PATCH v4 07/12] libvduse: Provide _GNU_SOURCE when compiling outside of QEMU, Marcel Holtmann, 2022/12/22
- [PATCH v4 08/12] libvduse: Switch to unsigned int for inuse field in struct VduseVirtq, Marcel Holtmann, 2022/12/22
- [PATCH v4 10/12] libvhost-user: Fix assignment in vring_set_avail_event,
Marcel Holtmann <=
- [PATCH v4 09/12] libvduse: Fix assignment in vring_set_avail_event, Marcel Holtmann, 2022/12/22
- [PATCH v4 12/12] libvduse: Add extra compiler warnings, Marcel Holtmann, 2022/12/22
- [PATCH v4 11/12] libvhost-user: Add extra compiler warnings, Marcel Holtmann, 2022/12/22
- Re: [PATCH v4 00/12] Compiler warning fixes for libvhost-user,libvduse, Paolo Bonzini, 2022/12/23