qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 00/12] Compiler warning fixes for libvhost-user,libvduse


From: Paolo Bonzini
Subject: Re: [PATCH v4 00/12] Compiler warning fixes for libvhost-user,libvduse
Date: Fri, 23 Dec 2022 16:21:33 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1

On 12/22/22 21:36, Marcel Holtmann wrote:
The libvhost-user and libvduse libraries are also useful for external
usage outside of QEMU and thus it would be nice if their files could
be just copied and used. However due to different compiler settings, a
lot of manual fixups are needed. This is the first attempt at some
obvious fixes that can be done without any harm to the code and its
readability.

Marcel Holtmann (12):
   libvhost-user: Provide _GNU_SOURCE when compiling outside of QEMU
   libvhost-user: Replace typeof with __typeof__
   libvhost-user: Cast rc variable to avoid compiler warning
   libvhost-user: Use unsigned int i for some for-loop iterations
   libvhost-user: Declare uffdio_register early to make it C90 compliant
   libvhost-user: Change dev->postcopy_ufd assignment to make it C90 compliant
   libvduse: Provide _GNU_SOURCE when compiling outside of QEMU
   libvduse: Switch to unsigned int for inuse field in struct VduseVirtq
   libvduse: Fix assignment in vring_set_avail_event
   libvhost-user: Fix assignment in vring_set_avail_event
   libvhost-user: Add extra compiler warnings
   libvduse: Add extra compiler warnings

  subprojects/libvduse/libvduse.c           |  9 ++++--
  subprojects/libvduse/meson.build          |  8 ++++-
  subprojects/libvhost-user/libvhost-user.c | 36 +++++++++++++----------
  subprojects/libvhost-user/meson.build     |  8 ++++-
  4 files changed, 42 insertions(+), 19 deletions(-)


Looks good, but what happened to "libvhost-user: Switch to unsigned int for inuse field in struct VuVirtq"?

(I can pick it up from v3, no need to respin).

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]