[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 09/12] libvduse: Fix assignment in vring_set_avail_event
From: |
Marcel Holtmann |
Subject: |
[PATCH v4 09/12] libvduse: Fix assignment in vring_set_avail_event |
Date: |
Thu, 22 Dec 2022 21:36:48 +0100 |
Since the assignment is causing a compiler warning, fix it by using
memcpy instead.
CC libvduse.o
libvduse.c: In function ‘vring_set_avail_event’:
libvduse.c:603:7: error: dereferencing type-punned pointer will break
strict-aliasing rules [-Werror=strict-aliasin]
603 | *((uint16_t *)&vq->vring.used->ring[vq->vring.num]) = htole16(val);
| ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Suggested-by: Xie Yongji <xieyongji@bytedance.com>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
---
subprojects/libvduse/libvduse.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/subprojects/libvduse/libvduse.c b/subprojects/libvduse/libvduse.c
index 338ad5e352e7..377959a0b4fb 100644
--- a/subprojects/libvduse/libvduse.c
+++ b/subprojects/libvduse/libvduse.c
@@ -582,7 +582,8 @@ void vduse_queue_notify(VduseVirtq *vq)
static inline void vring_set_avail_event(VduseVirtq *vq, uint16_t val)
{
- *((uint16_t *)&vq->vring.used->ring[vq->vring.num]) = htole16(val);
+ uint16_t val_le = htole16(val);
+ memcpy(&vq->vring.used->ring[vq->vring.num], &val_le, sizeof(uint16_t));
}
static bool vduse_queue_map_single_desc(VduseVirtq *vq, unsigned int *p_num_sg,
--
2.38.1
- [PATCH v4 00/12] Compiler warning fixes for libvhost-user,libvduse, Marcel Holtmann, 2022/12/22
- [PATCH v4 01/12] libvhost-user: Provide _GNU_SOURCE when compiling outside of QEMU, Marcel Holtmann, 2022/12/22
- [PATCH v4 02/12] libvhost-user: Replace typeof with __typeof__, Marcel Holtmann, 2022/12/22
- [PATCH v4 03/12] libvhost-user: Cast rc variable to avoid compiler warning, Marcel Holtmann, 2022/12/22
- [PATCH v4 04/12] libvhost-user: Use unsigned int i for some for-loop iterations, Marcel Holtmann, 2022/12/22
- [PATCH v4 06/12] libvhost-user: Change dev->postcopy_ufd assignment to make it C90 compliant, Marcel Holtmann, 2022/12/22
- [PATCH v4 05/12] libvhost-user: Declare uffdio_register early to make it C90 compliant, Marcel Holtmann, 2022/12/22
- [PATCH v4 07/12] libvduse: Provide _GNU_SOURCE when compiling outside of QEMU, Marcel Holtmann, 2022/12/22
- [PATCH v4 08/12] libvduse: Switch to unsigned int for inuse field in struct VduseVirtq, Marcel Holtmann, 2022/12/22
- [PATCH v4 10/12] libvhost-user: Fix assignment in vring_set_avail_event, Marcel Holtmann, 2022/12/22
- [PATCH v4 09/12] libvduse: Fix assignment in vring_set_avail_event,
Marcel Holtmann <=
- [PATCH v4 12/12] libvduse: Add extra compiler warnings, Marcel Holtmann, 2022/12/22
- [PATCH v4 11/12] libvhost-user: Add extra compiler warnings, Marcel Holtmann, 2022/12/22
- Re: [PATCH v4 00/12] Compiler warning fixes for libvhost-user,libvduse, Paolo Bonzini, 2022/12/23