Re: [PATCH v6 0/7] Add ARM Cortex-R52 CPU

[Tobias Röhmel]

Thanks for all the help, I learned a lot!

Best regards,

Tobias

On 19.12.22 18:05, Peter Maydell wrote:
> On Tue, 6 Dec 2022 at 10:25, <tobias.roehmel@rwth-aachen.de> wrote:
> > From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
> >
> > Sorry for the "Reviewed-by" messup. I missed that on the explanation
> > page. Thanks again for the review :)
> >
> > v6:
> > patch 5:
> > - I also changed HPRENR from ARM_CP_ALIAS to ARM_CP_NO_RAW.
> >    Its state is also present in the HPRLAR registers,
> >    but it doesn't make sense to access it raw. (I think)
> > - I'm freeing the PRBAR/... strings explicitly now since
> >    I don't know how to use autofree in this setup correctly.
> >    Maybe {} around the part were the string is created/used,
> >    such that it is dropped at }?
> Applied to target-arm.next; thanks for your efforts in getting
> this patchset through the code review process.
>
> -- PMM