Re: [PULL 00/39] riscv-to-apply queue

[Alistair Francis]

On Fri, Dec 20, 2024 at 6:45 AM Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> Hi Alistair,
> Please take a look at the following CI failure:
>
> x86_64-w64-mingw32-gcc -m64 -Ilibqemuutil.a.p -I. -I.. -Iqapi -Itrace -Iui 
> -Iui/shader -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0 
> -I/usr/x86_64-w64-mingw32/sys-root/mingw/lib/glib-2.0/include 
> -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/p11-kit-1 
> -fdiagnostics-color=auto -Wall -Winvalid-pch -Werror -std=gnu11 -O2 -g 
> -fstack-protector-strong -Wempty-body -Wendif-labels -Wexpansion-to-defined 
> -Wformat-security -Wformat-y2k -Wignored-qualifiers -Wimplicit-fallthrough=2 
> -Winit-self -Wmissing-format-attribute -Wmissing-prototypes -Wnested-externs 
> -Wold-style-declaration -Wold-style-definition -Wredundant-decls 
> -Wshadow=local -Wstrict-prototypes -Wtype-limits -Wundef -Wvla 
> -Wwrite-strings -Wno-missing-include-dirs -Wno-psabi 
> -Wno-shift-negative-value -iquote . -iquote /builds/qemu-project/qemu -iquote 
> /builds/qemu-project/qemu/include -iquote 
> /builds/qemu-project/qemu/host/include/x86_64 -iquote 
> /builds/qemu-project/qemu/host/include/generic -iquote 
> /builds/qemu-project/qemu/tcg/i386 -mms-bitfields -mcx16 -msse2 -D_GNU_SOURCE 
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fno-strict-aliasing -fno-common 
> -fwrapv -fno-pie -no-pie -ftrivial-auto-var-init=zero 
> -fzero-call-used-regs=used-gpr -mms-bitfields -pthread -mms-bitfields -MD -MQ 
> libqemuutil.a.p/meson-generated_.._trace_trace-hw_riscv.c.obj -MF 
> libqemuutil.a.p/meson-generated_.._trace_trace-hw_riscv.c.obj.d -o 
> libqemuutil.a.p/meson-generated_.._trace_trace-hw_riscv.c.obj -c 
> trace/trace-hw_riscv.c
> In file included from trace/trace-hw_riscv.c:5:
> ../hw/riscv/trace-events: In function 
> '_nocheck__trace_riscv_iommu_sys_msi_sent':
> ../hw/riscv/trace-events:19:22: error: format '%lx' expects argument of type 
> 'long unsigned int', but argument 6 has type 'uint64_t' {aka 'long long 
> unsigned int'} [-Werror=format=]
>    19 | riscv_iommu_sys_msi_sent(uint32_t vector, uint64_t msi_addr, uint32_t 
> msi_data, uint32_t result) "MSI sent to vector %u msi_addr 0x%lx msi_data 
> 0x%x result %u"
>       |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ......
> ../hw/riscv/trace-events:19:22: error: format '%lx' expects argument of type 
> 'long unsigned int', but argument 3 has type 'uint64_t' {aka 'long long 
> unsigned int'} [-Werror=format=]
>    19 | riscv_iommu_sys_msi_sent(uint32_t vector, uint64_t msi_addr, uint32_t 
> msi_data, uint32_t result) "MSI sent to vector %u msi_addr 0x%lx msi_data 
> 0x%x result %u"
>       |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~                      
>                                                         ~~~~~~~~
>       |                                                                       
>                                                         |
>       |                                                                       
>                                                         uint64_t {aka long 
> long unsigned int}
> cc1: all warnings being treated as errors
>
> https://gitlab.com/qemu-project/qemu/-/jobs/8691704969#L2578
>
> Once the issue has been solved, please send a new revision of this pull

Sorry about that, v2 sent.

Alistair

> request.
>
> Thanks,
> Stefan