Re: Suggested update for spamass-milter

[Cassandra Lynette Brockett]

I just grabbed the CVS tree of the milter, and compiled the milter for my
system.

When I installed it I noticed it was not sending the full username to
spamc, at least that was how the system was handling things...

Below is the log entries from spamass-milter and spamd for a test message.
 I have replaced the real username with fakeuser to cut the spam
possibilities.

-------- Log Output --------
Dec 23 13:11:10 hotline spamass-milter[24669]: calling /usr/sbin/sendmail
-bv "<address@hidden>" 2>&1
Dec 23 13:11:10 hotline spamass-milter[24669]: sendmail output:
<address@hidden>... deliverable: mailer local, user fakeuser
Dec 23 13:11:10 hotline spamass-milter[24669]: user: fakeuser
Dec 23 13:11:10 hotline spamass-milter[24669]: Total of 1 actual recipients
Dec 23 13:11:10 hotline spamass-milter[24669]: output "X-Envelope-From:
<address@hidden>^M "
Dec 23 13:11:10 hotline spamass-milter[24669]: output "X-Envelope-To: ^M "
Dec 23 13:11:10 hotline spamass-milter[24669]: output "Received: from
ariegman.demon.nl (ariegman.demon.nl [82.161.5.28]) by
hotline.ophiuchi.net; ^M "
Dec 23 13:11:10 hotline spamass-milter[24669]: remembering fakeuser for spamc
Dec 23 13:11:10 hotline spamass-milter[24669]: remembering recipient
<address@hidden>
Dec 23 13:11:12 hotline sendmail[25015]: hBNLB9HW025015:
from=<address@hidden>, size=867, class=0, nrcpts=1,
msgid=<address@hidden>, proto=SMTP, daemon=MTA,
relay=ariegman.demon.nl [82.161.5.28]
Dec 23 13:11:12 hotline spamass-milter[25020]: spamc gets fakeuser
Dec 23 13:11:12 hotline spamass-milter[24669]: output "X-Envelope-From:
<address@hidden>^M X-Envelope-To: ^M Received: from
ariegman.demon.nl (ariegman.demon.nl [82.161.5.28]) by
hotline.ophiuchi.net; ^M "
Dec 23 13:11:12 hotline spamass-milter[24669]: output "Received: from
[60.24.14.0] ^Iby ariegman.demon.nl; ^ISat, 16 Nov 2002 00:15:15 -0400^M "
Dec 23 13:11:12 hotline spamass-milter[24669]: output "Message-ID:
<address@hidden>^M "
Dec 23 13:11:12 hotline spamass-milter[24669]: output "From: "Kristi
Johnson" <address@hidden>^M "
Dec 23 13:11:12 hotline spamass-milter[24669]: output "Reply-To: "Kristi
Johnson" <address@hidden>^M "
Dec 23 13:11:12 hotline spamass-milter[24669]: output "To:
address@hidden "
Dec 23 13:11:12 hotline spamass-milter[24669]: output "Subject: Lose those
holiday pounds^M "
Dec 23 13:11:12 hotline spamass-milter[24669]: output "Date: Sat, 16 Nov
02 00:15:15 +0200^M "
Dec 23 13:11:12 hotline spamass-milter[24669]: output "X-Mailer: AOL 7.0
for Windows US sub 118^M "
Dec 23 13:11:12 hotline spamass-milter[24669]: output "MIME-Version: 1.0^M "
Dec 23 13:11:12 hotline spamass-milter[24669]: output "Content-Type:
multipart/alternative; ^Iboundary="289B_.B__FFFED_B."                     
                  ^M "
Dec 23 13:11:12 hotline spamass-milter[24669]: output "^M "
Dec 23 13:11:12 hotline spamass-milter[24669]: output "^M
--289B_.B__FFFED_B.^M Content-Type: text/html;^M
Content-Transfer-Encoding: quoted-printable^M ^M a to z address@hidden@cy
choices<BR>^M have your Rx with confidence ^M <A
HREF=3D"http://www.rxsaleweb.biz/store/";><FONT COLOR=3D"NAVY">Browse No=^M
w</FONT></A><BR><BR>^M <A HREF=3D"http://www.rxsaleweb.biz/a.html";><FONT
COLOR=3D"SILVER">no than=^M ks</FONT></A>^M ^M --289B_.B__FFFED_B.--^M ^M
"
Dec 23 13:11:13 hotline spamd[24265]: connection from
localhost.localdomain [127.0.0.1] at port 42652
Dec 23 13:11:13 hotline spamd[25021]: info: setuid to fakeuser succeeded
Dec 23 13:11:13 hotline spamd[25021]: processing message
<address@hidden> for fakeuser:509.
Dec 23 13:11:19 hotline spamd[25021]: identified spam (19.2/5.0) for
fakeuser:509 in 7.0 seconds, 1057 bytes.
Dec 23 13:11:19 hotline spamass-milter[24669]: input  "X-Envelope-From:
<address@hidden> X-Envelope-To:  Received: from
ariegman.demon.nl (ariegman.demon.nl [82.161.5.28]) by hotline.
-------- Log Output --------

The message listed is a spam message so I don't care if people spam the
user or host listed in that :-)

I have checked with a manual test and if I send the correct username to
spamc (ie. spamc -u address@hidden etc...) then the spamc process
handles things correctly, so I can only assume that the code is not
handling the username pass-through correctly.

Just to check, the code appears to list that a username
<address@hidden> would be passed through in full, not just
<address@hidden> being passed through in full, that is correct?  I
hope so as that will be a necessary thing for us here.

--
Regards,
   Cassandra

Cassandra Lynette Brockett said:
> That sounds great.  The message suggests we can access cvs trees on
> savannah at the moment, if so I'll grab a copy.
>
> I'm am not in a rush for it at the moment (we need to get the replacement
> hosting server built yet, and I've been lazy, we've mainly been doing
> testing to verify things will work the way we expect them too...), so I
> can wait a few more days for it if I can't get it today, I was expecting
> it to take a week or so for the addition to happen anyway :-)
>
> --
> Regards,
>    Cassandra
>
> Dan Nelson said:
>> In the last episode (Dec 19), Cassandra Lynette Brockett said:
>>> At the moment a username is sent to spam[cd] as the localpart only,
>>> this causes a few issues if you are handling virtualdomains on the
>>> mailserver.  Here's an example :-
>>>
>>> User 1 - address@hidden (it's a fake testing domain)
>>> User 2 - address@hidden (again, another fake domain).
>> [...]
>>> Therefore is there a way an option could be added to spamass-milter
>>> (even if it is --work-with-cyrus or something like that if all the
>>> single-letters are taken *grin*), which would hand over full
>>> recipient usernames to the local spam[cd] process.
>>
>> The CVS source already does that, with the -e flag.  Of course, with
>> savannah down, you can't get it :(  As soon as it comes back up I'll
>> roll another release.  Their current message says it'll be up today,
>> but I wouldn't be surprised if it took a couple more days.
>>
>> Until then, using this in place of the regular local_user function in
>> spamass-milter.cpp should do what you want:
>>
>> string
>> SpamAssassin::local_user()
>> {
>>   // assuming we have a recipient in the form:
>> <address@hidden>
>>   // we return 'address@hidden'
>>   if (_rcpt[0]=='<')
>>     return _rcpt.substr(1,_rcpt.find('>')-1);
>>   else
>>     return _rcpt;
>> }
>>
>> --
>>      Dan Nelson
>>      address@hidden
>>
>
>
>
> _______________________________________________
> Spamass-milt-list mailing list
> address@hidden
> http://mail.nongnu.org/mailman/listinfo/spamass-milt-list
>