Re: x-popup-menu pops up at funny positions

[Jan D.]

Jan D. wrote:
> Hello.
>
> While trying to reproduce a reported problem with x-popup-menu (that 
> problem seems to be gone), I saw that x-popup-menu doesn't put the menu 
> in the correct position if the (x y) variant is used, like this:
>
> (x-popup-menu
>  (list '(1 1) (selected-window))
>  (list "title" (cons "title" '(("ignore" 'ignore)))
>        ))
>
> For lucid and motif, this puts the popup menu at a position that would 
> be correct if the Emacs edit window is at (0 0) on the root window.  If 
> Emacs is
> anywhere else on the root window, this is wrong.
>
> Here is a patch to fix that.  Is it OK to check in?

Since I normally don't use the menu bar, I got it wrong.  Here is a correct 
patch.

        Jan D.

Index: src/xmenu.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xmenu.c,v
retrieving revision 1.239
diff -c -r1.239 xmenu.c
*** src/xmenu.c 23 Dec 2002 18:06:42 -0000      1.239
--- src/xmenu.c 3 Jan 2003 17:12:49 -0000
***************
*** 2279,2315 ****
                           popup_deactivate_callback,
                           menu_highlight_callback);
  
-   /* Adjust coordinates to relative to the outer (window manager) window.  */
-   {
-     Window child;
-     int win_x = 0, win_y = 0;
- 
-     /* Find the position of the outside upper-left corner of
-        the inner window, with respect to the outer window.  */
-     if (f->output_data.x->parent_desc != FRAME_X_DISPLAY_INFO 
(f)->root_window)
-       {
-       BLOCK_INPUT;
-       XTranslateCoordinates (FRAME_X_DISPLAY (f),
- 
-                              /* From-window, to-window.  */
-                              f->output_data.x->window_desc,
-                              f->output_data.x->parent_desc,
- 
-                              /* From-position, to-position.  */
-                              0, 0, &win_x, &win_y,
- 
-                              /* Child of window.  */
-                              &child);
-       UNBLOCK_INPUT;
-       x += win_x;
-       y += win_y;
-       }
-   }
- 
-   /* Adjust coordinates to be root-window-relative.  */
-   x += f->output_data.x->left_pos;
-   y += f->output_data.x->top_pos;
- 
    dummy.type = ButtonPress;
    dummy.serial = 0;
    dummy.send_event = 0;
--- 2279,2284 ----
***************
*** 2318,2327 ****
    dummy.root = FRAME_X_DISPLAY_INFO (f)->root_window;
    dummy.window = dummy.root;
    dummy.subwindow = dummy.root;
-   dummy.x_root = x;
-   dummy.y_root = y;
    dummy.x = x;
    dummy.y = y;
    dummy.state = (FRAME_X_DISPLAY_INFO (f)->grabbed >> 1) * Button1Mask;
    dummy.button = 0;
    for (i = 0; i < 5; i++)
--- 2287,2302 ----
    dummy.root = FRAME_X_DISPLAY_INFO (f)->root_window;
    dummy.window = dummy.root;
    dummy.subwindow = dummy.root;
    dummy.x = x;
    dummy.y = y;
+   /* Adjust coordinates to be root-window-relative.  */
+   x += f->output_data.x->left_pos + f->output_data.x->x_pixels_diff;
+   y += f->output_data.x->top_pos
+     + f->output_data.x->menubar_height
+     + f->output_data.x->y_pixels_outer_diff;
+   
+   dummy.x_root = x;
+   dummy.y_root = y;
    dummy.state = (FRAME_X_DISPLAY_INFO (f)->grabbed >> 1) * Button1Mask;
    dummy.button = 0;
    for (i = 0; i < 5; i++)