emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Updated project-specific settings patch


From: Stefan Monnier
Subject: Re: Updated project-specific settings patch
Date: Mon, 19 May 2008 17:57:06 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

>> Better use the same buffer name *Local Variables*.
>> 
>>> +       ((file-exists-p (concat dir ".dir-settings.el"))
>>> +   (setq result (concat dir ".dir-settings.el")))
>> 
>> In most cases, we'd prefer (expand-file-name ".dir-settings.el" dir)
>> over the use of `concat'.  The only exception I know is when `dir' is
>> relative and it's important for the result also be relative.

> If the file name or directory has been read directly from disk and thus
> may contain "~" or "~USER" as valid literal components, you don't want
> to have those expanded.

That simply depends on what the result is used for.

In 99% of the cases in Emacs, the difference between the two
doesn't matter.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]