emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [SUSPECTED SPAM] Re: [Emacs-diffs] scratch/widen-less a4ba846: Repla


From: Eli Zaretskii
Subject: Re: [SUSPECTED SPAM] Re: [Emacs-diffs] scratch/widen-less a4ba846: Replace prog-widen with consolidating widen calls
Date: Sat, 09 Dec 2017 13:05:02 +0200

> Date: Sat, 09 Dec 2017 12:47:04 +0200
> From: Eli Zaretskii <address@hidden>
> Cc: address@hidden, address@hidden
> 
> > Then, some consumers might have doubt which ones to use, and might opt 
> > to reference the variable. In that case, we lose all benefits of having 
> > it a function (like making its implementation somehow smarter later), 
> > and the only benefit remaining is backward compatibility of having a 
> > function with that name.
> > 
> > But! Like with PREV-CHUNKS, prog-first-column (and the later prog-widen) 
> > are supposed to be used by the major modes only. There are no references 
> > to either of these functions in the latest antlr-mode.el, and there 
> > shouldn't be.
> > 
> > And as long as all the calls to that function are inside Emacs, we're 
> > free to change it however, including turning it into a variable.
> 
> These all are very weak reasons in my eyes.

Just to make myself clear: these reasons would have been very relevant
and serious if we were now considering the prog-indentation-context
stuff for inclusion in Emacs.  But we are 2 years past that stage, so
other considerations take precedence, I think.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]