emms-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emms-patches] Fix regression in emms-lastfm.el


From: Tassilo Horn
Subject: [Emms-patches] Fix regression in emms-lastfm.el
Date: Sat, 16 Dec 2006 14:44:26 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.91 (gnu/linux)

Hi all,

,----
| Sat Dec 16 14:22:09 CET 2006  Tassilo Horn <address@hidden>
|   * fix-regression-in-lastfm.dpatch
| 
|   My last path enabled emms-lastfm.el to submit tracks even if you
|   paused them. I tested this extensively! But I didn't test if it
|   still submits them if you don't pause it. Of course it didn't. ;-)
| 
|   The problem was that I rely on `emms-playing-time' to calculate when
|   a track has to be submitted. But in `emms-player-started-hook' my
|   new track function was run *before* `emms-playing-time' was set to 0
|   again.
`----

BTW: I think that `emms-playing-time' should always be enabled and only
the displaying in the mode-line should be deactivatable via
`emms-playing-time'. What do you think?

BTW2: Do you use some non-default indentation style? When having a look
at some other emms files I wonder how they were formatted. My emacs 22
with the normal emacs-lisp-mode indents differently...

Bye,
Tassilo

Attachment: fix-regression-in-lastfm.dpatch
Description: A patch for your repository

-- 
A morning without coffee is like something without something else.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]