Re: [Emms-patches] Fix regression in emms-lastfm.el

[Tassilo Horn]

On Monday 18 December 2006 06:02, William Xu wrote:

Hi William,

> > BTW: I think that `emms-playing-time' should always be enabled and
> > only the displaying in the mode-line should be deactivatable via
> > `emms-playing-time'. What do you think?
>
> I think you could check and warn if `emms-playing-time' isn't enabled.

Ok, I'll do that.

> And, besides current `emms-playing-time-toggle', i can add a new
> `emms-playing-time-toggle-display' toggling displaying on mode-line
> while running `emms-playing-time' internally. How does this sound?

Sounds good to me. My intention was that there's only one reason to
disable emms-playing-time, and that is saving some space on the
mode-line. I think the docs should reflect this and tell the user that
some functionality rely on `emms-playing-time', but disabling its
display is ok.

> > BTW2: Do you use some non-default indentation style? When having a
> > look at some other emms files I wonder how they were formatted. My
> > emacs 22 with the normal emacs-lisp-mode indents differently...
>
> Seems normal here, with default indentation style, of course. Maybe you
> could point out `some other emms files'.

For example the `progn' in `emms-playing-time', the `setq' in
`emms-default-players' or the `let' and all `setq's in
`emms-playlist-mode'.

Bye and thanks,
Tassilo