[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ft-devel] FreeType patches to support amalgamation
From: |
Werner LEMBERG |
Subject: |
Re: [ft-devel] FreeType patches to support amalgamation |
Date: |
Tue, 21 Feb 2012 08:38:09 +0100 (CET) |
Hello Vinnie!
Thanks a lot for your work. I only have a single comment; everything
else looks fine.
In file `4.patch':
> -#define RAS_ARGS /* void */
> -#define RAS_ARG /* void */
> +#define black_RAS_ARGS /* void */
> +#define black_RAS_ARG /* void */
>
> -#define RAS_VARS /* void */
> -#define RAS_VAR /* void */
> +#define black_RAS_VARS /* void */
> +#define black_RAS_VAR /* void */
I think this is a bad change since it unnecessarily uglifies the
source. It should be fully sufficient to have
#undef RAS_ARGS
#undef RAS_ARG
#undef RAS_VARS
#undef RAS_VAR
#define RAS_ARGS black_PWorker worker,
#define RAS_ARG black_PWorker worker
#define RAS_VARS worker,
#define RAS_VAR worker
(and similar code for `gray') as you've done elsewhere too.
Am I missing something? Otherwise please redo this patch.
Werner
Re: [ft-devel] FreeType patches to support amalgamation, Antoine Leca, 2012/02/21
- Re: [ft-devel] FreeType patches to support amalgamation, Alexei Podtelezhnikov, 2012/02/21
- Re: [ft-devel] FreeType patches to support amalgamation, Alexei Podtelezhnikov, 2012/02/21
- Re: [ft-devel] FreeType patches to support amalgamation, Dmitry Timoshkov, 2012/02/21
- Re: [ft-devel] FreeType patches to support amalgamation, Alan Coopersmith, 2012/02/21
- Re: [ft-devel] FreeType patches to support amalgamation, Antoine Leca, 2012/02/22
Re: [ft-devel] FreeType patches to support amalgamation,
Werner LEMBERG <=
Re: [ft-devel] FreeType patches to support amalgamation, Werner LEMBERG, 2012/02/21
Re: [ft-devel] FreeType patches to support amalgamation, suzuki toshiya, 2012/02/22
Re: [ft-devel] FreeType patches to support amalgamation, Werner LEMBERG, 2012/02/22
Re: [ft-devel] FreeType patches to support amalgamation, Werner LEMBERG, 2012/02/24