|
From: | Nikolaus Waxweiler |
Subject: | Re: [ft-devel] CMake patches from Microsoft's vcpkg project |
Date: | Sun, 18 Mar 2018 13:45:15 +0000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
Here's what I have so far: https://github.com/madig/freetype2/blob/modernize-cmake-build/CMakeLists.txt
I cribbed the SO version thing from https://git.libssh.org/projects/libssh.git -- contains more examples and is touted by the #cmake IRC channel as a good example.
One difference is in how export/import attributes are triggered. Compare https://git.libssh.org/projects/libssh.git/tree/include/libssh/libssh.h?id=c3c492a190475a96bddcfe3a10da74f7a0e0baba#n24 with https://github.com/madig/freetype2/blob/5bd76524ef786d942b28dc52618aeda3aebfa3d6/include/freetype/config/ftconfig.h#L456I have to pass in FT2_BUILD_LIBRARY for static and shared builds, otherwise I get plenty of errors. Shouldn't this only be necessary for shared builds?
Also, do we need the VC project build definitions? CMake 3.0 supports Visual Studio 6 up to 12 for example. I would remove them.
[Prev in Thread] | Current Thread | [Next in Thread] |