Re: [Gnash-dev] youtube bugs for release

[Benjamin Wolsey]

Am Samstag, den 28.02.2009, 16:31 +0100 schrieb Michael Fötsch:
> John Gilmore wrote:
> > The trunk (as of a few days ago) still has serious bugs with Youtube's
> > embedded player, the largest of which is that it floats a big "play
> > button" in the middle of the video window for the entire time the
> > video is playing (obscuring the video).
> 
> I think I found the cause. It's in the way Gnash handles 
> "super.method()" when the derived method is invoked via 
> "method.apply(this)" and not via "this.method()". This breaks YouTube's 
> event handling code.

I've committed a fix for the bug shown in the new tests. We weren't
assigning super when manually constructing the fn_call in
as_function::apply(), so super was undefined when executing the function
body. YouTube fullscreen now works, which is excellent, and possibly
some other buttons are working better. Clicking on the thumbnails at the
end of the video still doesn't have any effect.

Because it's a one-line YouTube fix, I'll put it in the release too.

bwy

--
Use Gnash, the GNU Flash Player!
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil