|
From: | Andrea Palmatè |
Subject: | Re: [Gnash-dev] std::bad_cast |
Date: | Fri, 15 May 2009 09:20:40 +0200 |
User-agent: | Thunderbird 2.0.0.21 (Windows/20090302) |
Benjamin Wolsey ha scritto:
i would do the same thing but there is no way at moment to implement it since AmigaOS itself doesn't support wide strings and also our G++ compiler has it disabled so it is impossible for us to implement it(b) fix either boost string predicates or wstring on AmigaOS. The first way is obviously better for Gnash and portability, the second way would benefit AmigaOS :) I don't like putting patches into trunk just to fix a build when the patches don't have the same functionality, and personally I would prefer these to remain as patches for AmigaOS users until a fix suitable for release code is found.
there are only few places at moment where those functions are called and also wstring is used in a few places. Why implement a thing that could be replaced with two instructions? Another soultion could be: Split the String_as.cpp in two. String_as.cpp and WString_as.cpp so at configure time we can choose the right one and using always the same functions but choosen using the correct fileAnyway, if anyone would like to work on a string implementation for ActionScript, I can supply my patch as a start. It supplied a libICU and a std::string implementation, but should really use a std::wstring type with some extra constructors to pass all the testsuite. The very time consuming part is finding the right places to use it more than anything else.
Andrea
[Prev in Thread] | Current Thread | [Next in Thread] |