Re: [Kawa-commonlisp-dev] [PATCH] Type refactoring.

[Jamison Hope]

Happy belated birthday, Charles!

On Aug 18, 2012, at 4:18 PM, Charles Turner wrote:

> So this is the part I'm least looking forward to. Sincere apologies in
> advance. :-)

Oh, it's not so bad. It touches a lot of files, but the conceptual
change is small.

> The motivation for this set of changes is that Scheme#getTypeMap is
> mostly applicable to other language, esp CL, so I'd like to move it
> into Language. Also, Scheme#checkDefaultBinding has a lot of stuff
> that can be put to good use for other languages, but it needs
> refactoring to check the respective language's type map for certain
> lookups.
>
> My first micro-patch is to move away from the various static helper
> methods in Scheme/Language, so that we can put Java's abstraction
> facilities to better use. This has been a trickle of changes to other
> languages that were calling things like Scheme.getNamedType. Those are
> now changed to Scheme.getInstance().getNamedType().
>
> Later patches will rely on the removal of these static modifiers.
>
> Charles.
> <types.patch>


Looks good to me. This stuff has been in need of some refactoring love
for a long time, what with how Scheme is a dependency for all the other
languages (which in theory should be on equal footing with it).


--
Jamison Hope
The PTR Group
www.theptrgroup.com