kawa-commonlisp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Kawa-commonlisp-dev] [PATCH] Type refactoring.


From: Charles Turner
Subject: Re: [Kawa-commonlisp-dev] [PATCH] Type refactoring.
Date: Sun, 19 Aug 2012 23:53:24 +0100

On 19 August 2012 23:42, Per Bothner <address@hidden> wrote:
> I don't think that's any improvement.  It doesn't help modularity
> at all, since we still have "Scheme" hardwired where we wouldn't.
>
> What I think we need to do is move string2Type and getNamedType
> up into Language or LispLanguage.  I'm guessing that is your intent,
> but I don't think this intermediate step has any use - it just
> means that everything has to be changed twice, without any
> benefit that I can see.

This is my seemingly perpetual problem, either the patches are too
large and contain several "logical" chunks (apparently bad practice),
or they're too small and as you point out, overlap. I'm finding it
difficult converge at a happy medium, apologies.

Indeed, that was my intent, that and more have been factored out in my
repository. I'll carve a new patch tomorrow that takes the type
refactoring a few steps further, then.

Regards,

Charles.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]