Re: [Kawa-commonlisp-dev] [PATCH] Type refactoring.

[Jamison Hope]

On Aug 19, 2012, at 6:53 PM, Charles Turner wrote:

> On 19 August 2012 23:42, Per Bothner <address@hidden> wrote:
> > I don't think that's any improvement.  It doesn't help modularity
> > at all, since we still have "Scheme" hardwired where we wouldn't.
> >
> > What I think we need to do is move string2Type and getNamedType
> > up into Language or LispLanguage.  I'm guessing that is your intent,
> > but I don't think this intermediate step has any use - it just
> > means that everything has to be changed twice, without any
> > benefit that I can see.
>
> This is my seemingly perpetual problem, either the patches are too
> large and contain several "logical" chunks (apparently bad practice),
> or they're too small and as you point out, overlap. I'm finding it
> difficult converge at a happy medium, apologies.

It's a very subjective thing. I don't mind seeing a bunch of small
changes that walk me through the updates in baby steps, but Per is
the one who has to do the svn committing, so his say goes. :-)

> Indeed, that was my intent, that and more have been factored out in my
> repository. I'll carve a new patch tomorrow that takes the type
> refactoring a few steps further, then.

Don't forget that tomorrow (later today for you) is the official Pencils
Down (19:00 UTC). I think it's OK if we're still getting stuff checked
in after that, but just for the record let's have one big patch in the
mailing list archives with everything remaining in it (with text in the
email stating the revision number it's diffed against). That way we can
prove that subsequent [PATCH] emails shouldn't count as new developments
on your part.

Jamie

--
Jamison Hope
The PTR Group
www.theptrgroup.com