kawa-commonlisp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Kawa-commonlisp-dev] [PATCH] Type refactoring.


From: Charles Turner
Subject: Re: [Kawa-commonlisp-dev] [PATCH] Type refactoring.
Date: Mon, 20 Aug 2012 21:10:22 +0100

I decided to change my approach a little, and since the patch is
getting quite large, I thought it best to pause and get a check up.

The main difference is that in my repository, there's a static method,
getNamedLispType, that's supposed to be like getNamedType, only that
it can't be overrided in Scheme, so that scheme can call
LispLanguage.getNamedLispType, rather than the circular
super.getNamedType, which by definition must call getTypeMap, where it
is overridden. I didn't like this approach, so Scheme's getTypeMap
must suck in the type map from LispLanguage. I think this is more
elegant, whilst being a bit more expensive at load time.

string2Type hasn't been refactored, hence why there's still some odd
looking calls to Scheme from XQuery and others.

I don't think XQuery depends on Scheme specific types, the tests pass
when calling LispLanguage#getNamedType in lieu of Scheme#getNamedType
at least.

Charles.

Attachment: types.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]