kawa-commonlisp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Kawa-commonlisp-dev] [PATCH] Type refactoring.


From: Per Bothner
Subject: Re: [Kawa-commonlisp-dev] [PATCH] Type refactoring.
Date: Sun, 19 Aug 2012 15:42:45 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0

On 08/18/2012 01:18 PM, Charles Turner wrote:
My first micro-patch is to move away from the various static helper
methods in Scheme/Language, so that we can put Java's abstraction
facilities to better use. This has been a trickle of changes to other
languages that were calling things like Scheme.getNamedType. Those are
now changed to Scheme.getInstance().getNamedType().

I don't think that's any improvement.  It doesn't help modularity
at all, since we still have "Scheme" hardwired where we wouldn't.

What I think we need to do is move string2Type and getNamedType
up into Language or LispLanguage.  I'm guessing that is your intent,
but I don't think this intermediate step has any use - it just
means that everything has to be changed twice, without any
benefit that I can see.
--
        --Per Bothner
address@hidden   http://per.bothner.com/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]