Re: [Libreboot] Target candidate: Thinkpad T400s

[persmule]

   Hi all,
   I managed to enable the esata port on my t400s, by modifying the device
   tree as the patch attached.
   After applying the modification, two ports (ata5 and ata6) show up,

     [    1.352903] ahci 0000:00:1f.2: version 3.0
     [    1.353131] ahci 0000:00:1f.2: SSS flag set, parallel bus scan
     disabled
     [    1.353174] ahci 0000:00:1f.2: AHCI 0001.0200 32 slots 4 ports 3
     Gbps 0x33 impl SATA mode
     [    1.353178] ahci 0000:00:1f.2: flags: 64bit ncq sntf ilck stag pm
     led clo pio slum part ccc
     [    1.357940] scsi host0: ahci
     [    1.358143] scsi host1: ahci
     [    1.358324] scsi host2: ahci
     [    1.358505] scsi host3: ahci
     [    1.358687] scsi host4: ahci
     [    1.358870] scsi host5: ahci
     [    1.358974] ata1: SATA max UDMA/133 abar address@hidden port
     0xe1b25100 irq 29
     [    1.358979] ata2: SATA max UDMA/133 abar address@hidden port
     0xe1b25180 irq 29
     [    1.358981] ata3: DUMMY
     [    1.358983] ata4: DUMMY
     [    1.358986] ata5: SATA max UDMA/133 abar address@hidden port
     0xe1b25300 irq 29
     [    1.358990] ata6: SATA max UDMA/133 abar address@hidden port
     0xe1b25380 irq

   and the integrated esata port turns out to be connected to ata6,

     [14425.386779] ata6: exception Emask 0x10 SAct 0x0 SErr 0x4050000
     action 0xe frozen
     [14425.386785] ata6: irq_stat 0x00400040, connection status changed
     [14425.386787] ata6: SError: { PHYRdyChg CommWake DevExch }
     [14425.386793] ata6: hard resetting link
     [14427.616054] ata6: SATA link up 3.0 Gbps (SStatus 123 SControl
     300)
     [14427.616858] ata6.00: ATA-8: TOSHIBA MK3252GSX, LV010D, max
     UDMA/100
     [14427.616861] ata6.00: 625142448 sectors, multi 16: LBA48 NCQ
     (depth 31/32), AA
     [14427.617783] ata6.00: configured for UDMA/100
     [14427.617792] ata6: EH complete

   while ata5 may be used to connect a potential esata port on the dock
   ([1]http://www.thinkwiki.org/wiki/ThinkPad_Dock_Series_3#ThinkPad_Mini_
   Dock_Plus_Series_3_-_90W)
   Besides, this patch may also be valuable for t400 and t500, since at
   least one dock for them
   ([2]http://www.thinkwiki.org/wiki/ThinkPad_Advanced_Dock) has a
   (P/S)ATA device ([3]Ultrabay Enhanced), which may use one those two
   ports to work.
   在 2016年05月19日 23:20, Iru Cai 写道:

   On Thu, May 19, 2016 at 9:53 PM, persmule <address@hidden>
   wrote:

   Hi all,
   libreboot git 3a7c7c3a376cd262c58440052b9e298efd713a27 (Sat May 14
   18:09:47 2016 +0100) failed to recover from suspension (by folding the
   laptop) on my t400s, but succeeded on my x200. I do not know whether
   this problem relates to high resolution screen.
   Besides, the microsata and ultrabay (optical drive) port work fine, but
   there is an additional esatap port on t400s comparing with t400, and
   the port is inactive when firmware for t400 is used:

     [    1.459363] ahci 0000:00:1f.2: version 3.0
     [    1.459574] ahci 0000:00:1f.2: SSS flag set, parallel bus scan
     disabled
     [    1.459605] ahci 0000:00:1f.2: AHCI 0001.0200 32 slots 4 ports 3
     Gbps 0x3 impl SATA mode
     [    1.459609] ahci 0000:00:1f.2: flags: 64bit ncq sntf ilck stag pm
     led clo pio slum part ccc
     [    1.460593] scsi host0: ahci
     [    1.460786] scsi host1: ahci
     [    1.460966] scsi host2: ahci
     [    1.461147] scsi host3: ahci
     [    1.461244] ata1: SATA max UDMA/133 abar address@hidden port
     0xe1b25100 irq 29
     [    1.461249] ata2: SATA max UDMA/133 abar address@hidden port
     0xe1b25180 irq 29
     [    1.461251] ata3: DUMMY
     [    1.461253] ata4: DUMMY

   How can I enable the port on t400s?


   You need to change the sata_port_map in devicetree.cb.

   Persmule
   在 2016年05月12日 20:49, Iru Cai 写道:

   Hi persmule,
   On Thu, May 12, 2016 at 8:25 PM, persmule <address@hidden>
   wrote:

   Hi all,
   Last time, in reality my t400s had not booted into GNU/Linux. I
   repeated the test just then, in which t400s gave correct video output
   after the kernel got booted, only no output on grub phase.
   Besides, is it possible to execute (chainload) seabios atop grub? I
   have tried to chainload bios.bin.elf on my x200, on which seabios seems
   able to execute memtest86-plus installed by debian, but with broken
   video output. It can also boot a grub installed on MBR, but after linux
   kernel get booted, the message below appeared on the console:

   You can use the sgabios in the SeaBIOS project. It can be used to boot
   GNU/Linux, but I forgot if it can work with memtest86+.
   [6]https://www.coreboot.org/SeaBIOS#Adding_sgabios_support
   Iru

     [    3.134931] i915 0000:00:02.0: Invalid PCI ROM header signature:
     expecting 0xaa55, got 0x0000

   It seems lacking a valid video bios. Is it vgabios.bin or similar file?
   If so, is it possible to load videobios along with bios.bin.elf?
   在 2016年05月11日 23:33, persmule 写道:

     Hi Leah Woods,
     I just built the libreboot images from the latest git repository,
     and flashed those images to my x200 and t400s, respectively.
     On x200 it shows that the century byte has been fixed. But t400s
     gives no video output at all (even after the kernel get booted), and
     I cannot find any LVDS-related patches within repo, so it seems that
     the certain elegant patch written by phcoder you have mentioned has
     not been included in this version.
     Besides, the script helping to build coreboot (invoked via ./build
     module coreboot) is very hard to use, for it is hard to either
     proceed or reset once the build-module command fails. I have to
     cache the result of './download coreboot' to recover from failure
     (caused by an over-strict '-Werror' switch within Makefile.inc to
     build a lex-generated file for cbfstool.
     Could you tell me how I can find the patch to enable dual-link LVDS
     automatically?
     Thanks.
     Persmule
     在 2016年05月10日 23:06, Leah Woods 写道:

     Hi Persmule
     Op 10/05/16 om 13:00 schreef Persmule:
     > Finally I get my T400s work by flashing it with rom for T400, and
     > apply the patch
     > 0014-northbridge-intel-gm45-Automatically-enable-second-L.patch
     > (attached, which I got from resources/libreboot/patch/ within the
     > latest master branch. I failed to find a more proper way to obtain
     > this patch) to enable dual-link LVDS automatically, as well as the
     > patch to enable centry byte
     > ([7]https://review.coreboot.org/#/c/11853/).
     Are you sure that this patch needs to be merged in libreboot?
     You're using the early patch that pehjota wrote, but phcoder in
     #coreboot wrote a better patch that auto-detects single/dual lane
     lvds, which libreboot has in the latest version from git.
     Libreboot also has the century byte fix already.
     Can you try the ROM images for T400 from the current
     libreboot-unstable snapshot at [8]https://libreboot.org/beta/ (or
     compiled from latest libreboot git repository) on your T400S, and
     say
     whether that works or not?

References

   Visible links
   1. 
http://www.thinkwiki.org/wiki/ThinkPad_Dock_Series_3#ThinkPad_Mini_Dock_Plus_Series_3_-_90W
   2. http://www.thinkwiki.org/wiki/ThinkPad_Advanced_Dock
   3. http://www.thinkwiki.org/wiki/UltraBay
   4. mailto:address@hidden
   5. mailto:address@hidden
   6. https://www.coreboot.org/SeaBIOS#Adding_sgabios_support
   7. https://review.coreboot.org/#/c/11853/
   8. https://libreboot.org/beta/

   Hidden links:
   9. mailto:address@hidden
  10. https://review.coreboot.org/#/c/11853/

0001-lenovo-t400-Enable-all-SATA-ports.patch
Description: Text Data

signature.asc
Description: OpenPGP digital signature