lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: penalty -> permission patch


From: Han-Wen Nienhuys
Subject: Re: penalty -> permission patch
Date: Sun, 07 May 2006 20:07:17 +0200
User-agent: Thunderbird 1.5 (X11/20060313)

Joe Neeman wrote:
On Sun, 7 May 2006 12:49, Han-Wen Nienhuys wrote:
Joe Neeman wrote:
I'm not entirely sure what you mean by this. Are you thinking of having
multiple Events? With a BreakEvent, PageBreakEvent and PageTurnEvent we
could tweak break-permission, page-break-permission and
page-turn-permission individually. Is this any nicer than having an
explicit 'forbid symbol, though?
Yes, I think this is clearer.  I'd rename break-permission to
line-break-permission, though.

We could figure out a way to combine these events in the input side in
single identifier, but let's keep them seperate for now, and worry about
the syntax later.

OK, here's another try.

Does it run make web unscathed?

It looks good except for

-       (breakable . #t)
+       (line-break-permission . allow)
        (X-extent . #f)
        (Y-extent . #f)
        (stencil . ,ly:line-spanner::print)
@@ -705,7 +705,7 @@
        (Y-offset . ,ly:staff-symbol-referencer::callback)
        (break-align-symbol . key-cancellation)
        (break-visibility . ,begin-of-line-invisible)
-       (breakable . #t)
+       (line-break-permission . allow)

there's a bit of confusion with the breakable property, because it both signals whether or not items are on nonmusical Paper_columns (see eg. the use of Item::is_breakable in separating-line-group-engraver.cc) and to signal whether a nonmusical column is in fact eligible as a line break (for which line-break-permission is the right property).

I think it would be better to get rid of this double use, and have a
'line-break-permission which should be in spaceable-grob or perhaps paper-column, and is controlled with BreakEvents, while there also is a 'non-musical property, part of item-interface. (a better name for non-musical is of course welcome)



--

Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen

LilyPond Software Design
 -- Code for Music Notation
http://www.lilypond-design.com





reply via email to

[Prev in Thread] Current Thread [Next in Thread]