lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: penalty -> permission patch


From: Joe Neeman
Subject: Re: penalty -> permission patch
Date: Mon, 8 May 2006 18:26:20 +1000
User-agent: KMail/1.8.3

On Mon, 8 May 2006 04:07, Han-Wen Nienhuys wrote:
> there's a bit of confusion with the breakable property, because it both
> signals whether or not items are on nonmusical Paper_columns (see eg.
> the use of Item::is_breakable in separating-line-group-engraver.cc) and
>   to signal whether a nonmusical column is in fact eligible as a line
> break (for which line-break-permission is the right property).
>
> I think it would be better to get rid of this double use, and have a
> 'line-break-permission which should be in spaceable-grob or perhaps
> paper-column, and is controlled with BreakEvents, while there also is a
> 'non-musical property, part of item-interface.  (a better name for
> non-musical is of course welcome)

Should I then split Item::is_breakable into, say, Item::is_non_musical and 
Paper_column::is_breakable?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]