[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Improve implementation of dashed slurs
From: |
joeneeman |
Subject: |
Re: Improve implementation of dashed slurs |
Date: |
Fri, 17 Apr 2009 19:47:13 +0000 |
Very pretty slurs!
http://codereview.appspot.com/41099/diff/1021/59
File lily/bezier.cc (right):
http://codereview.appspot.com/41099/diff/1021/59#newcode275
Line 275: Bezier::subdivide (Real t, Bezier &left_part, Bezier
&right_part)
We only use references if they are const (for clarity), so please change
the arguments to pointers. Also, this function can be marked as const.
http://codereview.appspot.com/41099/diff/1021/59#newcode296
Line 296: Bezier::extract (Real t_min, Real t_max)
const here too
http://codereview.appspot.com/41099/diff/1021/59#newcode302
Line 302: bez2.control_[i] = control_[i];
bez2 = *this
http://codereview.appspot.com/41099/diff/1021/62
File lily/lookup.cc (right):
http://codereview.appspot.com/41099/diff/1021/62#newcode347
Line 347: SCM dash_details)
Since dash_details seems to just be a list of Reals, perhaps its better
to have a vector<Real> const& (with an empty vector to signify a solid
slur).
http://codereview.appspot.com/41099
- Re: adding snippets manually, (continued)
- Re: adding snippets manually, Valentin Villenave, 2009/04/18
- Re: adding snippets manually, John Mandereau, 2009/04/20
- Re: adding snippets manually, John Mandereau, 2009/04/21
- Re: adding snippets manually, John Mandereau, 2009/04/24
- Re: adding snippets manually, Graham Percival, 2009/04/24
Re: Improve implementation of dashed slurs, Neil Puttock, 2009/04/18
Re: Improve implementation of dashed slurs,
joeneeman <=
Re: Improve implementation of dashed slurs, Carl D. Sorensen, 2009/04/18