lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Enhancement: tabalture chord repetition (issue224082)


From: n . puttock
Subject: Re: Enhancement: tabalture chord repetition (issue224082)
Date: Sun, 14 Mar 2010 22:15:23 +0000

Hi Marc,

Here are a few more comments for you.

Cheers,
Neil



http://codereview.appspot.com/224082/diff/1012/17
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/224082/diff/1012/17#newcode256
Documentation/notation/fretted-strings.itely:256: is provided. It
preserves the string information explicitly given within
provided.  It

http://codereview.appspot.com/224082/diff/1012/17#newcode259
Documentation/notation/fretted-strings.itely:259:
@lilypond[quote,ragged-right,verbatim]
[quote,verbatim]

http://codereview.appspot.com/224082/diff/1012/18
File input/regression/tablature-chord-repetition.ly (right):

http://codereview.appspot.com/224082/diff/1012/18#newcode1
input/regression/tablature-chord-repetition.ly:1: \version "2.13.15"
"2.13.16"

http://codereview.appspot.com/224082/diff/1012/18#newcode3
input/regression/tablature-chord-repetition.ly:3: \header{ texidoc = "In
a TabStaff, the chord repetition function needs
\header {
  texidoc =

}

http://codereview.appspot.com/224082/diff/1012/19
File ly/chord-repetition-init.ly (right):

http://codereview.appspot.com/224082/diff/1012/19#newcode71
ly/chord-repetition-init.ly:71: (make-repeat-chord-function '() '()))
indent

#(define
   (make

http://codereview.appspot.com/224082/diff/1012/19#newcode74
ly/chord-repetition-init.ly:74: (make-repeat-chord-function
'(StringNumberEvent) '(StringNumberEvent)))
indent

http://codereview.appspot.com/224082/diff/1012/20
File ly/property-init.ly (right):

http://codereview.appspot.com/224082/diff/1012/20#newcode384
ly/property-init.ly:384: tabChordRepetition =
move to music-functions-init.ly

http://codereview.appspot.com/224082/diff/1012/20#newcode386
ly/property-init.ly:386: (ly:parser-set-repetition-function parser
tab-repeat-chord)
docstring above this line

(_i "Docme.")

http://codereview.appspot.com/224082/show




reply via email to

[Prev in Thread] Current Thread [Next in Thread]