Re: Enhancement: tablature chord repetition (issue224082)

[Marc Hohl]

address@hidden schrieb:
> Hi Marc,
>
> Here are a few more comments for you.
>
> Cheers,
> Neil
>
>
>
> http://codereview.appspot.com/224082/diff/1012/17
> File Documentation/notation/fretted-strings.itely (right):
>
> http://codereview.appspot.com/224082/diff/1012/17#newcode256
> Documentation/notation/fretted-strings.itely:256: is provided. It
> preserves the string information explicitly given within
> provided.  It
Ok. I found some spacing errors in the lines above, so I changed them 
accordingly.
> http://codereview.appspot.com/224082/diff/1012/17#newcode259
> Documentation/notation/fretted-strings.itely:259:
> @lilypond[quote,ragged-right,verbatim]
> [quote,verbatim]
Done.
> http://codereview.appspot.com/224082/diff/1012/18
> File input/regression/tablature-chord-repetition.ly (right):
>
> http://codereview.appspot.com/224082/diff/1012/18#newcode1
> input/regression/tablature-chord-repetition.ly:1: \version "2.13.15"
> "2.13.16"
Done.
> http://codereview.appspot.com/224082/diff/1012/18#newcode3
> input/regression/tablature-chord-repetition.ly:3: \header{ texidoc = "In
> a TabStaff, the chord repetition function needs
> \header {
>   texidoc =
>
> }
Ok.
> http://codereview.appspot.com/224082/diff/1012/19
> File ly/chord-repetition-init.ly (right):
>
> http://codereview.appspot.com/224082/diff/1012/19#newcode71
> ly/chord-repetition-init.ly:71: (make-repeat-chord-function '() '()))
> indent
>
> #(define
>    (make
Ok, but I thought that 2 spaces is the right indentation, no?
By the way, that's not consistent in ly/music-functions-init.ly, either.
> http://codereview.appspot.com/224082/diff/1012/19#newcode74
> ly/chord-repetition-init.ly:74: (make-repeat-chord-function
> '(StringNumberEvent) '(StringNumberEvent)))
> indent
Ok (see above).
> http://codereview.appspot.com/224082/diff/1012/20
> File ly/property-init.ly (right):
>
> http://codereview.appspot.com/224082/diff/1012/20#newcode384
> ly/property-init.ly:384: tabChordRepetition =
> move to music-functions-init.ly
Done.
> http://codereview.appspot.com/224082/diff/1012/20#newcode386
> ly/property-init.ly:386: (ly:parser-set-repetition-function parser
> tab-repeat-chord)
> docstring above this line
>
> (_i "Docme.")
Done. I hope the Docstring is ok.

Thanks for your comments!

Marc

http://codereview.appspot.com/224082/show