lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add tab-tie-follow-engraver (issue2723043)


From: n . puttock
Subject: Re: Add tab-tie-follow-engraver (issue2723043)
Date: Tue, 16 Nov 2010 23:30:41 +0000


http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc
File lily/tab-tie-follow-engraver.cc (right):

http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode52
lily/tab-tie-follow-engraver.cc:52: void process_acknowledged ();
remove

http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode64
lily/tab-tie-follow-engraver.cc:64: ties_.push_back (dynamic_cast
<Spanner *> (info.grob ()));
push_back (info.spanner ())

http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode70
lily/tab-tie-follow-engraver.cc:70: glissandi_.push_back (dynamic_cast
<Spanner *> (info.grob ()));
push_back (info.spanner ())

http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode76
lily/tab-tie-follow-engraver.cc:76: note_heads_.push_back
(dynamic_cast<Item *> (info.grob ()));
push_back (info.item ())

http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode82
lily/tab-tie-follow-engraver.cc:82: slurs_.push_back
(dynamic_cast<Spanner *> (info.grob ()));
push_back (info.spanner ())

http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode86
lily/tab-tie-follow-engraver.cc:86:
Tab_tie_follow_engraver::process_acknowledged ()
remove

http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode108
lily/tab-tie-follow-engraver.cc:108: Item *slur_cause =
dynamic_cast<Item *> (unsmob_grob (left_cause));
unsmob_item (left_cause)

http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode121
lily/tab-tie-follow-engraver.cc:121: if ((left_bound == note_heads_[k]))
remove extra parentheses

http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode154
lily/tab-tie-follow-engraver.cc:154:
gratuitous newline

http://codereview.appspot.com/2723043/diff/70001/scm/define-grob-interfaces.scm
File scm/define-grob-interfaces.scm (right):

http://codereview.appspot.com/2723043/diff/70001/scm/define-grob-interfaces.scm#newcode214
scm/define-grob-interfaces.scm:214: '(details display-cautionary))
?

tie-follow
span-start

http://codereview.appspot.com/2723043/diff/70001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/2723043/diff/70001/scm/define-grob-properties.scm#newcode1016
scm/define-grob-properties.scm:1016: (span-start ,boolean? "Is the note
at the start of a spanner?")
note head

http://codereview.appspot.com/2723043/diff/70001/scm/define-grob-properties.scm#newcode1023
scm/define-grob-properties.scm:1023: (tie-follow ,boolean? "Is the note
at the end of a tie?")
note head

http://codereview.appspot.com/2723043/diff/70001/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/2723043/diff/70001/scm/define-grobs.scm#newcode822
scm/define-grobs.scm:822: line-interface
indent

http://codereview.appspot.com/2723043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]