lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add tab-tie-follow-engraver (issue2723043)


From: marc
Subject: Re: Add tab-tie-follow-engraver (issue2723043)
Date: Sat, 27 Nov 2010 09:05:58 +0000

Hello Carl,

your code looks great (at least at a quick glance),
but it looks as you didn't rebase after my patch
correction concerning the custom fret label was applied.


http://codereview.appspot.com/2723043/diff/103001/scm/tablature.scm
File scm/tablature.scm (right):

http://codereview.appspot.com/2723043/diff/103001/scm/tablature.scm#newcode291
scm/tablature.scm:291: (grob-interpret-markup grob
(make-customFretLabel-markup fret)))
I think you reverted my corrected patch here, at least partly.
customFretLabel-markup isn't defined any more.

http://codereview.appspot.com/2723043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]