Re: Add tab-tie-follow-engraver (issue2723043)

[marc]

Just some remarks about the harmonic detection.

Regards,

Marc


http://codereview.appspot.com/2723043/diff/109001/scm/tablature.scm
File scm/tablature.scm (right):

http://codereview.appspot.com/2723043/diff/109001/scm/tablature.scm#newcode296
scm/tablature.scm:296: (harmonic (eq? (ly:grob-property grob 'style #f)
'harmonic))
I am not sure whether this approach is sane enough;
I would at least include mixed-harmonic, too.

When I worked on this, I used a different function:

(define (is-harmonic? grob)
  (let ((articulations (ly:event-property (event-cause grob)
'articulations))
        (harmonic-found #f))
    (for-each (lambda (art)
                (if (ly:in-event-class? art 'harmonic-event)
                    (set! harmonic-found #t)))
              articulations)
    harmonic-found))

This seems to work regardless of the user's choice of
harmonic display style.

http://codereview.appspot.com/2723043/