[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Reduces langdefs.py warnings in doc build (issue 6487046)
From: |
john . mandereau |
Subject: |
Re: Reduces langdefs.py warnings in doc build (issue 6487046) |
Date: |
Mon, 27 Aug 2012 14:37:31 +0000 |
I don't see the point of hiding/getting rid of these warnings, when
1) for now these warnings are harmless outside Documentation/??
2) if you want to get rid of the cause of the warning it should require
not more than adding at the beginning of
generic-targets.make:doc-stage-1
make -C $(top-build-dir)/Documentation/po out=www messages
(and possibly "make -C $(top-build-dir)/python out=")
(Similar trick could apply to test/test-baseline/check.)
http://codereview.appspot.com/6487046/diff/1/python/langdefs.py
File python/langdefs.py (right):
http://codereview.appspot.com/6487046/diff/1/python/langdefs.py#newcode101
python/langdefs.py:101: if not os.environ.has_key ('NO_GETTEXT'):
This doesn't make sense to me: if you want to disable the warning below
warning in all cases, which is what the patch seems to do, why not just
remove the "if os.environ.has_key ('LYDOC_LOCALEDIR')" block?
http://codereview.appspot.com/6487046/
Re: Reduces langdefs.py warnings in doc build (issue 6487046), Phil Holmes, 2012/08/31
Re: Reduces langdefs.py warnings in doc build (issue 6487046), john . mandereau, 2012/08/27