Re: Reduces langdefs.py warnings in doc build (issue 6487046)

[Phil Holmes]

----- Original Message ----- 
From: <address@hidden>
To: <address@hidden>; <address@hidden>; 
<address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Monday, August 27, 2012 3:37 PM
Subject: Re: Reduces langdefs.py warnings in doc build (issue 6487046)


> I don't see the point of hiding/getting rid of these warnings, when
> 1) for now these warnings are harmless outside Documentation/??
> 2) if you want to get rid of the cause of the warning it should require
> not more than adding at the beginning of
> generic-targets.make:doc-stage-1
>
> make -C $(top-build-dir)/Documentation/po out=www messages
>
> (and possibly "make -C $(top-build-dir)/python out=")
>
> (Similar trick could apply to test/test-baseline/check.)


I've just got back on this, and confirmed that adding

$(MAKE) -C $(top-build-dir)/Documentation/po out=www messages

to the top of the doc-stage-1 recipe gets rid of the warnings, so in fact it 
makes the build work correctly.  I've run a full make/make doc/make test 
with this change and would like to push directly to staging - given that it 
was John's suggestion, he knows what he's talking about, and it works and 
it's a further step in reducing the cruft from make doc.

Any objections?

--
Phil Holmes