lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: we now have "lilypond" organization on GitHub


From: Phil Holmes
Subject: Re: we now have "lilypond" organization on GitHub
Date: Sun, 22 Sep 2013 16:21:41 +0100

----- Original Message ----- From: "Urs Liska" <address@hidden>
To: "David Kastrup" <address@hidden>
Cc: "Julien Rioux" <address@hidden>; "LilyPond Developmet Team" <address@hidden>; "Han-Wen Nienhuys" <address@hidden>
Sent: Sunday, September 22, 2013 1:57 PM
Subject: Re: we now have "lilypond" organization on GitHub


Am 16.09.2013 12:50, schrieb David Kastrup:
Graham Percival <address@hidden> writes:

On Mon, Sep 16, 2013 at 10:49:42AM +0200, David Kastrup wrote:
What's wrong with GitHub, anyway?
It requires separate accounts and credentials (much more likely to be a
target for attacks), has its own "terms of service", may choose to
discontinue projects based on commercial criteria, can cause tool
lock-in and so on, relies on its own proprietary software.
All the above is true, but github also provides a nicer way for
developers to interact with git, by at least one order of
magnitude.
So the question is what we should be telling the Savannah operators to
make working on GNU projects using Git more feasible.

What about asking them to provide Gerrit as  a service?

As far as I've read:
- LilyPond uses Rietveld, which isn't designed for git workflows.
- Rietveld isn't integrated in the process of getting code into lilypond/master,
  but rather an artificial detour.
- For example the issue of commit messages that are finally pushed
  and don't match the reviewed code is probably related to that.
- Gerrit _is_ designed for git workflows.
- You could grant developer accounts to, say, anybody expressing serious intentions to contribute
- These could have the right to push the Gerrit
- The core developers have the right to approve/reject proposals
  as well as pushing directly to the main repo
- Approval of a patch immediately merges it into the main code base.
- This would make the way for externals' code into the main code base
  more straightforward and transparent.

Urs


IMHO this is solving a problem that doesn't exist. Using LilyDev (possibly in a Virtual Machine) provides git and git-cl. Git allows a developer to create a patch with 2 commands: git commit and git format-patch. That can be uploaded to Rietveld with a single command (possibly 2 commands, depending on what you were doing earlier). When the review is passed, it can be pushed to staging with 4 simple commands; or mailed to -devel for any active developer without push access - these are very rare.

How hard is that?

--
Phil Holmes



reply via email to

[Prev in Thread] Current Thread [Next in Thread]