|
From: | Urs Liska |
Subject: | Re: we now have "lilypond" organization on GitHub |
Date: | Wed, 18 Sep 2013 14:34:58 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
Am 18.09.2013 14:28, schrieb Janek Warchoł:
2013/9/18 Janek Warchoł <address@hidden>:2013/9/17 Urs Liska <address@hidden>:But as far as I've understood, code doesn't get into upstream master that way anyway, there is the Rietveld code review stage in between? How do commits (from developers) actually end up in master?It's c) they are usually not pushed to any branch, unless it's a big or long-running change (think "Mike's skylines"). If you want to base some new work on a yet unmerged patch, you usually need to ask the author to push the branch.
OK, and if someone without push access (e.g. me) had something to contribute, would the following process seem right?
1)Upload a patch to Rietveld and go through review, possibly changing the code.
2)When review is finished prepare a patch file (or series of patch files) and find someone with push access whom I can send it to?
Urs
[Prev in Thread] | Current Thread | [Next in Thread] |