Re: Add French-specific note names (issue 239930043 by address@hidden)

[dak]

https://codereview.appspot.com/239930043/diff/1/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):

https://codereview.appspot.com/239930043/diff/1/Documentation/notation/pitches.itely#newcode492
Documentation/notation/pitches.itely:492: @item @code{francais} or
@code{français}
Please don't introduce "francais".  If people want to input without
accents, they can do so using "italiano" in the first place.  And if
there is no point in naming a language "francais" rather than "français"
if people are supposed to input the language using accents.

https://codereview.appspot.com/239930043/diff/1/python/convertrules.py
File python/convertrules.py (right):

https://codereview.appspot.com/239930043/diff/1/python/convertrules.py#newcode3562
python/convertrules.py:3562: or re.search
('\\language\s(?!\s*#?"(?:catalan|espanol|español|italiano|francais| 
français|portugues|vlaams))"',
str)):
There are a number of things wrong here: first, we don't want a notename
language "francais" in the first place when the language is supposed to
support entry of "ré".  That's nonsensical.

Second, there is no point in treating "francais" anyway in a conversion
rule for 2.17.15 where it cannot possibly be defined as this patch is
intended for 2.17.21.

https://codereview.appspot.com/239930043/