Re: add stencil-whiteout-outline function (issue 236480043 by address@hidden)

[David Kastrup]

James Lowe <address@hidden> writes:

> On 08/06/15 19:23, Paul Morris wrote:
>> Ok.  Sounds like the CG would benefit from some updating on this
>> point, as it currently simply says to run makelsr (in 10.9.5)
>> before submitting for review (in 10.9.9).
>
> Yes it could be improved.
>
>> 
>> Sounds like you are saying there’s a way to run makelsr to test a
>> patch myself but then discard those changes so that what is
>> reviewed doesn’t include the results of makelsr?
>
>
> Yes. It's not the end of the world if you didn't do that, assuming the
> changes that makelsr ends up making itself aren't too large - but you
> should then make sure the commit message includes the fact that you
> ran makelsr
>
>  (I’m not sure how to do that…)

Always do that in a separate commit with only the changes from running
makelsr, like with

git commit -m "Run scripts/auxiliar/makelsr.py" -a

In general, always keep automated changes and manual changes in separate
commits in order to reduce clutter.

-- 
David Kastrup