Re: Define French as a separate input language (issue 288290043 by address@hidden)

[dak]

It seems to me (after glancing over it) like the last Rietveld review
was just abandoned and the same state resubmitted.

Any reason the suggestions have not been addressed?


https://codereview.appspot.com/288290043/diff/40001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):

https://codereview.appspot.com/288290043/diff/40001/Documentation/notation/pitches.itely#newcode505
Documentation/notation/pitches.itely:505: @item @code{francais} or
@code{français}
There still is no point in "francais" since to enter "ré", you need
utf-8 anyway, and if you are going to enter "re", you can use "italiano"
in the first place.

https://codereview.appspot.com/288290043/diff/40001/python/musicexp.py
File python/musicexp.py (right):

https://codereview.appspot.com/288290043/diff/40001/python/musicexp.py#newcode282
python/musicexp.py:282: "francais": pitch_francais,
Why "francais" here instead of "français"?

https://codereview.appspot.com/288290043/diff/40001/scm/define-note-names.scm
File scm/define-note-names.scm (right):

https://codereview.appspot.com/288290043/diff/40001/scm/define-note-names.scm#newcode555
scm/define-note-names.scm:555: (francais . (
français seems permitted as a symbol name in both Guile-1.8 and
Guile-2.0.

https://codereview.appspot.com/288290043/