Re: Process Resource Update

[rory]

I'll look at the BSD stuff when I get a chance.

> On Sat, 31 Jul 2004, Martin Pala wrote:
>
>> Seems to work good :) (i have tested on linux/x86 only).
>>
>> Yet two cosmetic questions:
>>
>> 1.) maybe it could be better not to use memset after calloc, bacause
>> calloc ensures that the memory is set to zero already. The redundant
>> use of memset will not hurt, but it is extra overhead (though very
>> small):
>>
>> --8<--
>>    pt = xcalloc(sizeof(ProcessTree_T), treesize);
>>    memset(pt, 0, sizeof(ProcessTree_T) * treesize);
>> --8<--
>
> Gonna remove it... mmmhhh... I should spend even more time reading
> man-pages. (:
>
>> 2.) it seems that the process related stuff needs to be fixed on
>> Darwin and OpenBSD:
>>
>> monit/process/sysdep_DARWIN.c (seems that process initialization is
>> skipped completely):
>>
>> --8<--
>> +  /* Put this here until fixed */
>> +
>> +#warning initprocesstree_sysdep: needs to be fixed!
>> +  return 0;
>> --8<--
>>
>> monit/process/sysdep_OPENBSD.c:
>>
>> --8<--
>> +#warning initprocesstree_sysdep: needs to be fixed!
>> +    /* getrusage code is wrong!!!
>> +       it only measures the rusage of the current process, that means
>> +       of monit itself.
>> +    */
>> --8<--
>
> Because IMO it won't work with the code... and a *BSD guy has to look
> over it.
>
>> Summary:
>> There are probably following options:
>>
>> 1.) either release 4.3.1 without this patch and add it as soon as it
>> will be verified/fixed on Darwin and/or OpenBSD.
>>
>> 2.) or add it now and fix it later (in future release)
>>
>> 3.) or just wait with 4.3.1 release
>
> Think officially release the patch  to the general mailing list and get
> the *BSD stuff fixed until release.  Or release a beta/rc or however you
> call it.
>
> Christian
>
> --
> Christian Hopp                                email:
> address@hidden Institut für Elektrische Informationstechnik
>           fon: +49-5323-72-2113 TU Clausthal, Leibnizstr. 28, 38678
> Clausthal-Zellerf.   fax: +49-5323-72-3197
>                              pgpkey:
> https://www.iei.tu-clausthal.de/pgp-keys/
>
>
>
> _______________________________________________
> monit-dev mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/monit-dev