Re: [Phpgroupware-developers] HEAD/18 proposals/issues

[Dave Hall]

On Tue, 2006-02-21 at 08:47 -0600, Chris Weiss wrote:
> On 2/20/06, Dave Hall <address@hidden> wrote:
> > There is also a lot of older stuff like:
> >
> > if($GLOBALS['phpgw_setup']->alessthanb($setup_info['phpgwapi']['currentver'],
> >  '0.9.10pre7'))
> 
> alessthanb is a nessicary evil (unless php has added version parsing
> function that I haven't noticed yet) because version numbers are
> compaired as strings and "0.9.16" is greater than "0.10.1".  to be
> clear, simple string comp would see 0.9.16 as the newer one when it
> isn't, so alessthenb was made to parse version strings and compair
> them correctly.

I am talking about removing the check as we would just support upgrading
from 0.9.14+ and so code like this would not be needed.  alessthanb
would remain :)

I am suggesting anywhere we check for phpgw versions < 0.9.14 (or php3)
should be removed.

Hope this clears things up :)

Cheers

Dave
-- 
Dave Hall (aka skwashd)
API Coordinator
phpGroupWare
+-------------------------------------+-------------------------------+
| e address@hidden          | w phpgroupware.org            |
| j address@hidden                 | aim skwashd                   |
| icq 278064022                       | msn address@hidden       |
| sip address@hidden       | y! skwashd                    |
+-------------------------------------+-------------------------------+