Re: [Qemu-devel] [PULL 00/48] ivshmem series

[Andrew Jones]

On Wed, Oct 07, 2015 at 08:16:40AM -0400, Marc-André Lureau wrote:
> 
> Hi Andreas
> 
> ----- Original Message -----
> > Am 06.10.2015 um 21:18 schrieb address@hidden:
> > > From: Marc-André Lureau <address@hidden>
> > > 
> > > The following changes since commit
> > > 5fdb4671b08e0d1631447e81348b2b50a6b85bf7:
> > > 
> > >   Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request'
> > >   into staging (2015-10-06 13:42:33 +0100)
> > > 
> > > are available in the git repository at:
> > > 
> > >   https://github.com/elmarco/qemu tags/ivshmem-series
> > > 
> > > for you to fetch changes up to 097cadb155ef22be286af1403240b4fbf0f038ef:
> > > 
> > >   ivshmem: use little-endian int64_t for the protocol (2015-10-06 21:17:22
> > >   +0200)
> > > 
> > > ----------------------------------------------------------------
> > > Ivshmem series
> > > 
> > > ----------------------------------------------------------------
> > [...]
> > > Marc-André Lureau (45):
> > [...]
> > >       tests: add ivshmem qtest
> > 
> > I had NAK'ed this patch in v1 and it has not been fixed. If this pull
> > gets merged I will immediately revert it. Not funny.
> > 
> 
> 
> Could stick to technical review, please. The test runs fine without kvm. 
> Regarding your copyright claim, I already explain that your older version of 
> boilerplate test is really nothing compare to this one. But if you feel so 
> strongly about it, I don't care you add a copyright line.
> 

I would care if we added it. If contributors are getting bullied into
outrageous demands, then there's something wrong. Something wrong is
something we should try to fix, not just shrug off. And, in this case,
Andreas' claim is quite outrageous. The patch[*] in question provided
absolutely nothing that couldn't have been copy+pasted from any other
qtest.

drew

[*] http://patchwork.ozlabs.org/patch/336367/