[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to" message |
Date: |
Mon, 8 Apr 2019 11:20:52 +0200 |
Hi
On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster <address@hidden> wrote:
>
> char_pty_open() prints a "char device redirected to PTY_NAME (label
> LABEL)" message to the current monitor or else to stderr. No other
> ChardevClass::open() prints anything on success. Drop the message.
>
> Cc: "Marc-André Lureau" <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> chardev/char-pty.c | 2 --
> 1 file changed, 2 deletions(-)
>
I guess that was printed for convenience.
Allocated pty can be read from "info chardev", so I suppose we can
make qemu more silent. Fine with me:
Reviewed-by: Marc-André Lureau <address@hidden>
> diff --git a/chardev/char-pty.c b/chardev/char-pty.c
> index b034332edd..a48d3e5d20 100644
> --- a/chardev/char-pty.c
> +++ b/chardev/char-pty.c
> @@ -211,8 +211,6 @@ static void char_pty_open(Chardev *chr,
> qemu_set_nonblock(master_fd);
>
> chr->filename = g_strdup_printf("pty:%s", pty_name);
> - error_printf("char device redirected to %s (label %s)\n",
> - pty_name, chr->label);
>
> s = PTY_CHARDEV(chr);
> s->ioc = QIO_CHANNEL(qio_channel_file_new_fd(master_fd));
> --
> 2.17.2
>
[Qemu-devel] [PATCH 05/15] mips/boston: Report errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 01/15] qemu-img: Use error_vreport() in error_exit(), Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 10/15] vl: Make -machine $TYPE, help and -accel help print to stdout, Markus Armbruster, 2019/04/08