[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to" message |
Date: |
Thu, 11 Apr 2019 12:47:44 +0100 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Tue, Apr 09, 2019 at 01:25:43PM +0200, Marc-André Lureau wrote:
> Hi
>
> On Tue, Apr 9, 2019 at 12:40 PM Philippe Mathieu-Daudé
> <address@hidden> wrote:
> >
> > On 4/8/19 2:31 PM, Markus Armbruster wrote:
> > > Marc-André Lureau <address@hidden> writes:
> > >
> > >> Hi
> > >>
> > >> On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster <address@hidden> wrote:
> > >>>
> > >>> char_pty_open() prints a "char device redirected to PTY_NAME (label
> > >>> LABEL)" message to the current monitor or else to stderr. No other
> > >>> ChardevClass::open() prints anything on success. Drop the message.
> > >>>
> > >>> Cc: "Marc-André Lureau" <address@hidden>
> > >>> Cc: Paolo Bonzini <address@hidden>
> > >>> Signed-off-by: Markus Armbruster <address@hidden>
> > >>> ---
> > >>> chardev/char-pty.c | 2 --
> > >>> 1 file changed, 2 deletions(-)
> > >>>
> > >>
> > >> I guess that was printed for convenience.
> > >>
> > >> Allocated pty can be read from "info chardev", so I suppose we can
> > >> make qemu more silent. Fine with me:
> > >>
> > >> Reviewed-by: Marc-André Lureau <address@hidden>
> > >
> > > Thanks!
> > >
> > > If we should decide the message is still useful enough to be worth
> > > keeping, I could direct it to stdout instead of dropping it.
> >
> > I prefer this, if Marc-André is still OK.
>
> I don't mind, but I wonder if we really have users that care. Power
> users can easily get the associated pty from a monitor query.
IMHO if people want predictable filenames for chardevs without needing to
lookup the name via the monitor, then UNIX sockets fill that need.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[Qemu-devel] [PATCH 05/15] mips/boston: Report errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 01/15] qemu-img: Use error_vreport() in error_exit(), Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 10/15] vl: Make -machine $TYPE, help and -accel help print to stdout, Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 04/15] loader-fit: Wean off error_printf(), Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 12/15] qemu-print: New qemu_printf(), qemu_vprintf() etc., Markus Armbruster, 2019/04/08