[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to" message |
|
Date: |
Mon, 08 Apr 2019 14:31:59 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Hi
>
> On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster <address@hidden> wrote:
>>
>> char_pty_open() prints a "char device redirected to PTY_NAME (label
>> LABEL)" message to the current monitor or else to stderr. No other
>> ChardevClass::open() prints anything on success. Drop the message.
>>
>> Cc: "Marc-André Lureau" <address@hidden>
>> Cc: Paolo Bonzini <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> chardev/char-pty.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>
> I guess that was printed for convenience.
>
> Allocated pty can be read from "info chardev", so I suppose we can
> make qemu more silent. Fine with me:
>
> Reviewed-by: Marc-André Lureau <address@hidden>
Thanks!
If we should decide the message is still useful enough to be worth
keeping, I could direct it to stdout instead of dropping it.
[Qemu-devel] [PATCH 05/15] mips/boston: Report errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 01/15] qemu-img: Use error_vreport() in error_exit(), Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 10/15] vl: Make -machine $TYPE, help and -accel help print to stdout, Markus Armbruster, 2019/04/08