Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to" message

[Marc-André Lureau]

Hi

On Tue, Apr 9, 2019 at 12:40 PM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> On 4/8/19 2:31 PM, Markus Armbruster wrote:
> > Marc-André Lureau <address@hidden> writes:
> >
> >> Hi
> >>
> >> On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster <address@hidden> wrote:
> >>>
> >>> char_pty_open() prints a "char device redirected to PTY_NAME (label
> >>> LABEL)" message to the current monitor or else to stderr.  No other
> >>> ChardevClass::open() prints anything on success.  Drop the message.
> >>>
> >>> Cc: "Marc-André Lureau" <address@hidden>
> >>> Cc: Paolo Bonzini <address@hidden>
> >>> Signed-off-by: Markus Armbruster <address@hidden>
> >>> ---
> >>>  chardev/char-pty.c | 2 --
> >>>  1 file changed, 2 deletions(-)
> >>>
> >>
> >> I guess that was printed for convenience.
> >>
> >> Allocated pty can be read from "info chardev", so I suppose we can
> >> make qemu more silent. Fine with me:
> >>
> >> Reviewed-by: Marc-André Lureau <address@hidden>
> >
> > Thanks!
> >
> > If we should decide the message is still useful enough to be worth
> > keeping, I could direct it to stdout instead of dropping it.
>
> I prefer this, if Marc-André is still OK.

I don't mind, but I wonder if we really have users that care. Power
users can easily get the associated pty from a monitor query.


-- 
Marc-André Lureau